Skip to content

Fixes #2571. Wizards background shifts to gray when focusing, looks bad.#3194

Merged
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_view-background-shift-to-gray-on-focus_2571
Jan 20, 2024
Merged

Fixes #2571. Wizards background shifts to gray when focusing, looks bad.#3194
tig merged 3 commits intogui-cs:developfrom
BDisp:v1_view-background-shift-to-gray-on-focus_2571

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Jan 20, 2024

Fixes

Proposed Changes/Todos

  • Allowing containers to use the normal attribute instead of the focused color
  • Adding unit test

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Jan 20, 2024

@tig I don't know why this is failing. All the test passed locally.

@tig tig merged commit 1d44f2e into gui-cs:develop Jan 20, 2024
@BDisp BDisp deleted the v1_view-background-shift-to-gray-on-focus_2571 branch January 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wizards background shifts to gray when focusing, looks bad.

2 participants